Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix in dev/NewtonMDS cmake #17

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Apr 3, 2020

  • Removed redundant " in library list that caused linking drivers to HiOp library to fail. This issue may be dependent on CMake version.
  • Set minimum CUDA version to 10.1, since HiOp depends on cublasLt, which is available only as of that version.

Fixes issue #16

@cnpetra
Copy link
Collaborator

cnpetra commented Apr 5, 2020

not sure what's happening: while I see two commits, there are no files changed ("Files changed 0")

@pelesh
Copy link
Collaborator Author

pelesh commented Apr 6, 2020

It seems I pushed changes to a wrong remote, sorry. It is in there now.

@pelesh
Copy link
Collaborator Author

pelesh commented Apr 13, 2020

@cnpetra, can you confirm if this fix works for you or if it breaks things apart?

By the way, this is a patchwork solution, just to make things work.

@cnpetra cnpetra merged commit b6ec914 into LLNL:dev/NewtonMDS Apr 14, 2020
@cnpetra
Copy link
Collaborator

cnpetra commented Apr 14, 2020

works fine, merged

ashermancinelli pushed a commit that referenced this pull request Jun 22, 2021
Shri/scopflow major refactor

Closes #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11, #12, #14, #17, #18, and #15

See merge request exasgd/frameworks/scopflow!2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants