Add CMake FortranCInterface to detect Fortran name mangling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! looks good, minimal changes. Will test and merge it once I get back from DC. |
|
@junkudo : is there any reason to require CMake 3.0 ? It is not present on quartz for example. I've changed it to 2.8. Other than that, everything worked fine and it is merged in the master now. Thanks again! |
|
I was under the assumption that FortranCInterface was only available on cmake v 3.0.2: https://cmake.org/cmake/help/v3.0/module/FortranCInterface.html. Apparently they back-ported it to 2.8? No idea. Glad it worked. |
ashermancinelli
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the CMake build scripts to use the FortranCInterface module to figure out the Fortran name mangling pattern during configuration. This commit modifies the corresponding source code to use the CMake generated macros.