-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/block interface #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- full Newton IPM will reuse base class
- fixed an issue in reallocating Jacobians after a change in the problem size
- HessianLowRank fakely inherits from a matrix to match the type of FullNewtonIPM Hessian
- code is incomplete
- work in progress
- work in progress
example working
valgrind-ed it
ashermancinelli
pushed a commit
that referenced
this pull request
Jun 22, 2021
IPOPT complains the Hessian is incorrect (for power balance polar form) for buses that are connected to branches with from bus number greater than to bus number (given in the network file). The finite-difference Hessian calculation for IPOPT shows small differences (of the order e-1) for such buses. A fix for the issue is to reverse the from bus and to bus numbers immediately after the data read. Added a flag `reversed_ends` in the branch data struct to set true for such branchs. The self and mutual admittances for the line also need to be reversed for lines with reversed ends.
ashermancinelli
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code works fine - valgrind only on Linux - but safe to merge since it does not influence existing users