Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'yajl/' path component is used by header files #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gahr
Copy link

@gahr gahr commented Jul 10, 2014

We do not need that in pkg-config's includedir.

gahr added a commit to freebsd/freebsd-ports that referenced this pull request Jul 10, 2014
splbio pushed a commit to splbio/freebsd-ports that referenced this pull request Nov 24, 2014
  lloyd/yajl#139


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@361480 35697150-7ecd-e111-bb59-0022644237b5
@edmonds
Copy link

edmonds commented Dec 18, 2015

This is the same patch as in #77. Fedora also does the same patch: http://pkgs.fedoraproject.org/cgit/yajl.git/tree/yajl-2.1.0-pkgconfig-includedir.patch. But Debian doesn't.

Would be nice if this could be merged, so that all the distros would agree on the include path...

@reedjc
Copy link

reedjc commented Jun 8, 2018

(I started making a new ticket and then saw a merge request already exists ...)

The two examples linked from https://lloyd.github.io/yajl/yajl-2.1.0/ and the example at https://lloyd.github.io/yajl/ show the #include uses header under yajl/ subdirectory. But yajl.pc.cmake has:

includedir=${dollar}{prefix}/include/yajl

So would look under include/yajl for yajl/. This is fixed in the FreeBSD package. https://svnweb.freebsd.org/ports/head/devel/yajl/Makefile?r1=358010&r2=361480

reedjc added a commit to farsightsec/dnstable that referenced this pull request Jun 8, 2018
YAJL 1 also installed the header  in subdirectory like that.
The YAJL documentation shows includes with yajl subdirectory.
Various packagers of yajl fix their broken pkg-config includedir.
A fix was reported to yajl lloyd/yajl#139

(Note that even though Debian has wrong includedir too, the compile
still works because /usr/include is default.)
alesage pushed a commit to farsightsec/dnstable that referenced this pull request Jun 20, 2018
YAJL 1 also installed the header  in subdirectory like that.
The YAJL documentation shows includes with yajl subdirectory.
Various packagers of yajl fix their broken pkg-config includedir.
A fix was reported to yajl lloyd/yajl#139

(Note that even though Debian has wrong includedir too, the compile
still works because /usr/include is default.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants