Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][InferWidths] Restore back-prop constraint for strictconnect. #5409

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[FIRRTL][InferWidths] Restore back-prop constraint for strictconnect. #5409

merged 1 commit into from
Jun 15, 2023

Conversation

dtzSiFive
Copy link
Contributor

Fix #5408.

Unfix #5391.

This partially reverts commit 6c01320.

@dtzSiFive dtzSiFive requested a review from uenoku June 15, 2023 12:51
uenoku
uenoku approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick fix!

@dtzSiFive dtzSiFive merged commit 5f9d04e into llvm:main Jun 15, 2023
@dtzSiFive dtzSiFive deleted the fix/infer-widths-revert branch June 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uenoku uenoku uenoku approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIRRTL] InferWidths failures
2 participants
@dtzSiFive @uenoku