[FIRRTL][CAPI] Fix undefined reference for mlirExportFIRRTL
#5790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpriteOvO
force-pushed
the
fix-firrtl-capi-export
branch
3 times, most recently
from
7fca40a
to
44935b0
Compare
mikeurbach
reviewed
Aug 7, 2023
SpriteOvO
force-pushed
the
fix-firrtl-capi-export
branch
from
44935b0
to
d3cbf7f
Compare
seldridge
reviewed
Aug 10, 2023
SpriteOvO
force-pushed
the
fix-firrtl-capi-export
branch
from
21c2c29
to
bb65d3d
Compare
|
Thanks for the reviews from @seldridge @mikeurbach, changes applied. |
seldridge
approved these changes
Aug 14, 2023
| // CHECK-NEXT: output out : UInt<32> @[- 4:45] | ||
| // CHECK-EMPTY: | ||
| // CHECK-NEXT: connect out, and(in_1, in_2) @[- 6:5] | ||
| } |
There was a problem hiding this comment.
This is a massive reduction in the size of this test from the original PR. Thanks! This helps test maintainability a lot.
Comment on lines
+107
to
+108
| static FIRVersion latestFIRVersion() { return {3, 0, 0}; } | ||
|
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 172afc3 added a new argument
FIRVersion versionto themlirExportFIRRTLfunction, but didn't update its declaration. It breaks the compile for this function.This PR removed that argument to fix the problem, since
FIRVersiondoes not have a CAPI yet, and added a simple test to prevent regression.