Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][IMCP] Refactor and generalize overdefined operations #5797

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[FIRRTL][IMCP] Refactor and generalize overdefined operations #5797

merged 1 commit into from
Aug 8, 2023

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Aug 8, 2023

This refactors a logic in markBlockExecutable and marks unhandled nullary operations (e.g. plusarg intrinsics).

@uenoku uenoku requested a review from jackkoenig August 8, 2023 09:56
dtzSiFive
dtzSiFive approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@uenoku uenoku merged commit e21bfff into main Aug 8, 2023
5 checks passed
@uenoku uenoku deleted the dev/uenoku/refactor-imcp-init branch August 8, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

@jackkoenig jackkoenig Awaiting requested review from jackkoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uenoku @dtzSiFive