Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pipeline] Use Block::BlockArgListType to avoid const. #6489

Merged

Conversation

dtzSiFive
Copy link
Contributor

ArrayRef makes the elements 'const' unnecessarily, causing issues with upcoming LLVM bump, due to http://llvm.org/PR72765 .

There's no BlockArgumentRange, so use Block's typedef (=MutableArrayRef).

ArrayRef<BlockArgument> makes the elements 'const' unnecessarily,
causing issues with upcoming LLVM bump, due to http://llvm.org/PR72765 .

There's no BlockArgumentRange, so use Block's typedef (=MutableArrayRef).
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks benign enough

@dtzSiFive dtzSiFive merged commit e8f841c into llvm:main Dec 5, 2023
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/prefer-blockarglisttype-for-constness branch December 5, 2023 01:29
@jackkoenig jackkoenig mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants