Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][DropConst] Fix performance with many extmodule's. #7126

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[FIRRTL][DropConst] Fix performance with many extmodule's. #7126

merged 1 commit into from
Jun 5, 2024

Conversation

dtzSiFive
Copy link
Contributor

Before, DropConst on FIRRTL w/300k extmodule's took 221s. Now it's < 1s.

@dtzSiFive
[FIRRTL][DropConst] Fix performance with many extmodule's.
b44646d 
Before, DropConst on FIRRTL w/300k extmodule's took 221s.
Now it's < 1s.
prithayan
prithayan approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good to know that skipping over ext modules can avoid significant redundant work.

@dtzSiFive
Copy link
Contributor Author

Nice, good to know that skipping over ext modules can avoid significant redundant work.

Apparently, yep!

Same idea basically as #6850/#6851, FWIW. getNumRegions vs filtering on FModuleOp specifically.

@dtzSiFive
Copy link
Contributor Author

Thanks for the review!

@dtzSiFive dtzSiFive merged commit 2189f25 into llvm:main Jun 5, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/drop-const-performance branch June 5, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prithayan prithayan prithayan approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @prithayan