Automatically set Ninja generator for --use-make=ninja #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `--use-make=ninja` or `--use-make=ninja.exe`, the build would previously fail because CMake was not instructed to generate the corresponding Ninja build files. It would default to generating Makefiles for Linux or Visual Studio MSBuild files for Windows. This change detects when the specified make program is ninja and automatically adds the `-G Ninja` flag to the CMake config step.
DavidSpickett
approved these changes
Jun 24, 2025
Sorry this is so late, just seeing this PR now. We were using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--use-make=ninjaor--use-make=ninja.exe, the build would previously fail because CMake was not instructed to generate the corresponding Ninja build files. It would default to generating Makefiles for Linux or Visual Studio MSBuild files for Windows.This change detects when the specified make program is ninja and automatically adds the
-G Ninjaflag to the CMake config step.