Pin Jinja2 to 2.11.3 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fc27f4 pinned MarkupSafe to 1.1.1, which lead to this error on our buildbots that are using Python 3.10 to run the lnt client: error: MarkupSafe 1.1.1 is installed but MarkupSafe>=2.0 is required by {'Jinja2'} Jinja2 2.11.3 is the last version that will work with that version of MarkupSafe: https://github.com/pallets/jinja/blob/2.11.3/setup.py The 3.x series moved to >= 2.0.0: https://github.com/pallets/jinja/blob/3.0.0rc1/setup.py
|
I know I'm risking blowing up some other workflow here, but it seems one worth taking to fix this short term. I see tox failures but those were mentioned elsewhere and you want to drop 3.9 anyway. If it would help to move the buildbots away from the setup.py install method, I can do that. As long as we have some overlapping time where the old and new methods work, it's not hard to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8fc27f4 pinned MarkupSafe to 1.1.1, which lead to this error on our buildbots that are using Python 3.10 to run the lnt client:
error: MarkupSafe 1.1.1 is installed but MarkupSafe>=2.0 is required by {'Jinja2'}
Jinja2 2.11.3 is the last version that will work with that version of MarkupSafe:
https://github.com/pallets/jinja/blob/2.11.3/setup.py
The 3.x series moved to >= 2.0.0:
https://github.com/pallets/jinja/blob/3.0.0rc1/setup.py