Skip to content

Commit 3a59407

Browse files
[CI] Make Postcommit Testing Pass In Correct Flags to Premerge Advisor
Before this patch we were passing in the previous commit rather than the current commit due to a copy and paste adjustment failure from the PR flow. We want the base SHA to just be the commit SHA for postcommit. We also were not attaching the run number which made the source ID the first JUnit XML file rather than the buildbot run number.
1 parent 10a975b commit 3a59407

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.ci/utils.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,17 @@ function at-exit {
4040
fi
4141

4242
if [[ "$retcode" != "0" ]]; then
43-
python "${MONOREPO_ROOT}"/.ci/premerge_advisor_upload.py \
44-
$(git rev-parse HEAD~1) $GITHUB_RUN_NUMBER \
45-
"${BUILD_DIR}"/test-results.*.xml "${MONOREPO_ROOT}"/ninja*.log
4643
if [[ "$GITHUB_ACTIONS" != "" ]]; then
4744
python "${MONOREPO_ROOT}"/.ci/premerge_advisor_explain.py \
4845
$(git rev-parse HEAD~1) "${BUILD_DIR}"/test-results.*.xml \
4946
"${MONOREPO_ROOT}"/ninja*.log
47+
python "${MONOREPO_ROOT}"/.ci/premerge_advisor_upload.py \
48+
$(git rev-parse HEAD~1) $GITHUB_RUN_NUMBER \
49+
"${BUILD_DIR}"/test-results.*.xml "${MONOREPO_ROOT}"/ninja*.log
50+
else
51+
python "${MONOREPO_ROOT}"/.ci/premerge_advisor_upload.py \
52+
$(git rev-parse HEAD) $BUILDBOT_BUILDNUMBER \
53+
"${BUILD_DIR}"/test-results.*.xml "${MONOREPO_ROOT}"/ninja*.log
5054
fi
5155
fi
5256
}

0 commit comments

Comments
 (0)