Skip to content

Commit e17bc1e

Browse files
authored
[VPlan] Explicitly predicate some replicate region sinking tests. NFC (#164934)
To remove some test diffs in #160449
1 parent 33609bd commit e17bc1e

File tree

2 files changed

+30
-12
lines changed

2 files changed

+30
-12
lines changed

llvm/test/Transforms/LoopVectorize/first-order-recurrence-sink-replicate-region.ll

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ exit:
102102
ret void
103103
}
104104

105-
define void @sink_replicate_region_2(i32 %x, i8 %y, ptr %ptr) optsize {
105+
define void @sink_replicate_region_2(i32 %x, i8 %y, ptr %ptr, i32 %z) optsize {
106106
; CHECK-LABEL: sink_replicate_region_2
107107
; CHECK: VPlan 'Initial VPlan for VF={2},UF>=1' {
108108
; CHECK-NEXT: Live-in vp<[[VF:%.+]]> = VF
@@ -125,16 +125,18 @@ define void @sink_replicate_region_2(i32 %x, i8 %y, ptr %ptr) optsize {
125125
; CHECK-NEXT: ir<%iv> = WIDEN-INDUCTION ir<0>, ir<1>, vp<[[VF]]>
126126
; CHECK-NEXT: EMIT vp<[[MASK:%.+]]> = icmp ule ir<%iv>, vp<[[BTC]]>
127127
; CHECK-NEXT: EMIT vp<[[SPLICE:%.+]]> = first-order splice ir<%recur>, ir<%recur.next>
128+
; CHECK-NEXT: WIDEN ir<%cond> = icmp eq ir<%iv>, ir<%z>
129+
; CHECK-NEXT: EMIT vp<[[AND:%.+]]> = logical-and vp<[[MASK]]>, ir<%cond>
128130
; CHECK-NEXT: Successor(s): pred.store
129131
; CHECK-EMPTY:
130132
; CHECK-NEXT: <xVFxUF> pred.store: {
131133
; CHECK-NEXT: pred.store.entry:
132-
; CHECK-NEXT: BRANCH-ON-MASK vp<[[MASK]]>
134+
; CHECK-NEXT: BRANCH-ON-MASK vp<[[AND]]>
133135
; CHECK-NEXT: Successor(s): pred.store.if, pred.store.continue
134136
; CHECK-EMPTY:
135137
; CHECK-NEXT: pred.store.if:
136-
; CHECK-NEXT: vp<[[STEPS:%.+]]> = SCALAR-STEPS vp<[[CAN_IV]]>, ir<1>
137138
; CHECK-NEXT: REPLICATE ir<%rem> = srem vp<[[SPLICE]]>, ir<%x>
139+
; CHECK-NEXT: vp<[[STEPS:%.+]]> = SCALAR-STEPS vp<[[CAN_IV]]>, ir<1>
138140
; CHECK-NEXT: REPLICATE ir<%gep> = getelementptr ir<%ptr>, vp<[[STEPS]]>
139141
; CHECK-NEXT: REPLICATE ir<%add> = add ir<%rem>, ir<%recur.next>
140142
; CHECK-NEXT: REPLICATE store ir<%add>, ir<%gep>
@@ -143,9 +145,9 @@ define void @sink_replicate_region_2(i32 %x, i8 %y, ptr %ptr) optsize {
143145
; CHECK-NEXT: pred.store.continue:
144146
; CHECK-NEXT: No successors
145147
; CHECK-NEXT: }
146-
; CHECK-NEXT: Successor(s): loop.0
148+
; CHECK-NEXT: Successor(s): if.1
147149
; CHECK-EMPTY:
148-
; CHECK-NEXT: loop.0:
150+
; CHECK-NEXT: if.1:
149151
; CHECK-NEXT: EMIT vp<[[CAN_IV_NEXT:%.+]]> = add nuw vp<[[CAN_IV]]>, vp<[[VFxUF]]>
150152
; CHECK-NEXT: EMIT branch-on-count vp<[[CAN_IV_NEXT]]>, vp<[[VEC_TC]]>
151153
; CHECK-NEXT: No successors
@@ -162,13 +164,20 @@ entry:
162164
br label %loop
163165

164166
loop:
165-
%recur = phi i32 [ 0, %entry ], [ %recur.next, %loop ]
166-
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
167-
%rem = srem i32 %recur, %x
167+
%recur = phi i32 [ 0, %entry ], [ %recur.next, %latch ]
168+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %latch ]
168169
%recur.next = sext i8 %y to i32
170+
%cond = icmp eq i32 %iv, %z
171+
br i1 %cond, label %if, label %latch
172+
173+
if:
174+
%rem = srem i32 %recur, %x
169175
%add = add i32 %rem, %recur.next
170176
%gep = getelementptr i32, ptr %ptr, i32 %iv
171177
store i32 %add, ptr %gep
178+
br label %latch
179+
180+
latch:
172181
%iv.next = add nsw i32 %iv, 1
173182
%ec = icmp eq i32 %iv.next, 20001
174183
br i1 %ec, label %exit, label %loop

llvm/test/Transforms/LoopVectorize/vplan-sink-scalars-and-merge.ll

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,13 @@ target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f3
2929
; CHECK-NEXT: EMIT vp<[[CAN_IV:%.+]]> = CANONICAL-INDUCTION
3030
; CHECK-NEXT: ir<%iv> = WIDEN-INDUCTION ir<0>, ir<1>, vp<[[VF]]>
3131
; CHECK-NEXT: EMIT vp<[[MASK:%.+]]> = icmp ule ir<%iv>, vp<[[BTC]]>
32+
; CHECK-NEXT: WIDEN ir<%cond> = icmp eq ir<%iv>, ir<%x>
33+
; CHECK-NEXT: EMIT vp<[[AND:%.+]]> = logical-and vp<[[MASK]]>, ir<%cond>
3234
; CHECK-NEXT: Successor(s): pred.store
3335

3436
; CHECK: <xVFxUF> pred.store: {
3537
; CHECK-NEXT: pred.store.entry:
36-
; CHECK-NEXT: BRANCH-ON-MASK vp<[[MASK]]>
38+
; CHECK-NEXT: BRANCH-ON-MASK vp<[[AND]]>
3739
; CHECK-NEXT: Successor(s): pred.store.if, pred.store.continue
3840

3941
; CHECK: pred.store.if:
@@ -50,24 +52,31 @@ target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f3
5052
; CHECK-NEXT: No successors
5153
; CHECK-NEXT: }
5254

53-
; CHECK: loop.1:
55+
; CHECK: if.1:
5456
; CHECK-NEXT: EMIT vp<[[CAN_IV_NEXT:%.+]]> = add nuw vp<[[CAN_IV]]>, vp<[[VFxUF]]>
5557
; CHECK-NEXT: EMIT branch-on-count vp<[[CAN_IV_NEXT]]>, vp<[[VEC_TC]]>
5658
; CHECK-NEXT: No successors
5759
; CHECK-NEXT: }
5860
;
59-
define void @sink1(i32 %k) {
61+
define void @sink1(i32 %k, i32 %x) {
6062
entry:
6163
br label %loop
6264

6365
loop:
64-
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
66+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %latch ]
67+
%cond = icmp eq i32 %iv, %x
68+
br i1 %cond, label %if, label %latch
69+
70+
if:
6571
%gep.b = getelementptr inbounds [2048 x i32], ptr @b, i32 0, i32 %iv
6672
%lv.b = load i32, ptr %gep.b, align 4
6773
%add = add i32 %lv.b, 10
6874
%mul = mul i32 2, %add
6975
%gep.a = getelementptr inbounds [2048 x i32], ptr @a, i32 0, i32 %iv
7076
store i32 %mul, ptr %gep.a, align 4
77+
br label %latch
78+
79+
latch:
7180
%iv.next = add i32 %iv, 1
7281
%large = icmp sge i32 %iv, 8
7382
%exitcond = icmp eq i32 %iv, %k

0 commit comments

Comments
 (0)