[BOLT] Change scheduling policy to SP_INT_LINEAR

- count the total applicable functions, and only run the passes if it's
  more than 0. This way we do not get a warning on the scheduling policy
  change.

Author: bgergely0

bolt/lib/Passes/InsertNegateRAStatePass.cpp

@@ -128,15 +128,26 @@ Error InsertNegateRAState::runOnFunctions(BinaryContext &BC) {
     return !BF.containedNegateRAState() || BF.isIgnored();
   };
 
-  ParallelUtilities::runOnEachFunction(
-      BC, ParallelUtilities::SchedulingPolicy::SP_TRIVIAL, WorkFun,
-      SkipPredicate, "InsertNegateRAStatePass");
-
-  BC.outs() << "BOLT-INFO: rewritten pac-ret DWARF info in "
-            << FunctionsModified << " out of " << BC.getBinaryFunctions().size()
-            << " functions "
-            << format("(%.2lf%%).\n", (100.0 * FunctionsModified) /
-                                          BC.getBinaryFunctions().size());
+  int Total = llvm::count_if(
+      BC.getBinaryFunctions(),
+      [&](std::pair<const unsigned long, BinaryFunction> &P) {
+        return P.second.containedNegateRAState() && !P.second.isIgnored();
+      });
+
+  // If we attempt to run the pass, but SkipPredicate skips all functions,
+  // we get a warning that the SchedulingPolicy is changed to trivial.
+  // This would break bolt/test/AArch64/unmarked-data.test.
+  if (Total != 0) {
+    ParallelUtilities::runOnEachFunction(
+        BC, ParallelUtilities::SchedulingPolicy::SP_INST_LINEAR, WorkFun,
+        SkipPredicate, "InsertNegateRAStatePass");
+
+    BC.outs() << "BOLT-INFO: rewritten pac-ret DWARF info in "
+              << FunctionsModified << " out of "
+              << BC.getBinaryFunctions().size() << " functions "
+              << format("(%.2lf%%).\n", (100.0 * FunctionsModified) /
+                                            BC.getBinaryFunctions().size());
+  }
   return Error::success();
 }
 

bolt/lib/Passes/MarkRAStates.cpp

@@ -134,19 +134,24 @@ Error MarkRAStates::runOnFunctions(BinaryContext &BC) {
     return !BF.containedNegateRAState() || BF.isIgnored();
   };
 
-  ParallelUtilities::runOnEachFunction(
-      BC, ParallelUtilities::SchedulingPolicy::SP_TRIVIAL, WorkFun,
-      SkipPredicate, "MarkRAStates");
-
   int Total = llvm::count_if(
       BC.getBinaryFunctions(),
       [&](std::pair<const unsigned long, BinaryFunction> &P) {
         return P.second.containedNegateRAState() && !P.second.isIgnored();
       });
-  BC.outs() << "BOLT-INFO: MarkRAStates ran on " << Total
-            << " functions. Ignored " << FunctionsIgnored << " functions "
-            << format("(%.2lf%%)", (100.0 * FunctionsIgnored) / Total)
-            << " because of CFI inconsistencies.\n";
+
+  // If we attempt to run the pass, but SkipPredicate skips all functions,
+  // we get a warning that the SchedulingPolicy is changed to trivial.
+  // This would break bolt/test/AArch64/unmarked-data.test.
+  if (Total != 0) {
+    ParallelUtilities::runOnEachFunction(
+        BC, ParallelUtilities::SchedulingPolicy::SP_INST_LINEAR, WorkFun,
+        SkipPredicate, "MarkRAStates");
+    BC.outs() << "BOLT-INFO: MarkRAStates ran on " << Total
+              << " functions. Ignored " << FunctionsIgnored << " functions "
+              << format("(%.2lf%%)", (100.0 * FunctionsIgnored) / Total)
+              << " because of CFI inconsistencies.\n";
+  }
 
   return Error::success();
 }