Skip to content

[mlir][tensor] Optimize bubbleUpPadSlice when high = 0 #112236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[mlir][tensor] Optimize bubbleUpPadSlice when high = 0 #112236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions mlir/lib/Dialect/Tensor/IR/TensorTilingInterfaceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,10 +792,9 @@ FailureOr<TilingResult> tensor::bubbleUpPadSlice(OpBuilder &b,
// ExtractSliceOp length will be zero in that case. (Effectively reading
// no data from the source.)
//
// Optimization: If low = 0, then the formula can be simplified.
OpFoldResult newOffset = hasLowPad
? min(max(sub(offset, low), zero), srcSize)
: min(offset, srcSize);
// Optimization: If low = 0 / high = 0, then the formula can be simplified.
OpFoldResult newOffset = hasLowPad ? max(sub(offset, low), zero) : offset;
newOffset = hasHighPad ? min(newOffset, srcSize) : newOffset;
newOffsets.push_back(newOffset);

// The original ExtractSliceOp was reading until position `offset +
Expand All @@ -816,11 +815,14 @@ FailureOr<TilingResult> tensor::bubbleUpPadSlice(OpBuilder &b,
//
// The new ExtractSliceOp length is `endLoc - newOffset`.
//
// Optimization: If low = 0, then the formula can be simplified.
OpFoldResult endLoc =
hasLowPad ? min(max(add(sub(offset, low), length), zero), srcSize)
: min(add(offset, length), srcSize);
OpFoldResult newLength = sub(endLoc, newOffset);
// Optimization: If low = 0 / high = 0, then the formula can be simplified.
OpFoldResult endLoc = hasLowPad ? max(add(sub(offset, low), length), zero)
: add(offset, length);
endLoc = hasHighPad ? min(endLoc, srcSize) : endLoc;

// Optimization: If low = 0 and high = 0, then length is the old length.
OpFoldResult newLength =
(hasLowPad && hasHighPad) ? length : sub(endLoc, newOffset);
newLengths.push_back(newLength);

// Check if newLength is zero. In that case, no SubTensorOp should be
Expand Down