[llvm][Docs] Clarify release ABI/API compatibility rules #123049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current release branch is version X, the phrase "the previous major release." sounds to me as if it is referring to releases of X-1. Not to the last release from the current release branch, which is what I think it intends. (if it meant X-1, then we could never change the ABI)
|
Maybe this is way more confusing, but you see my confusion here at least. |
tstellar
reviewed
Jan 15, 2025
|
ping! |
1 similar comment
|
ping! |
|
LGTM |
tru
approved these changes
Feb 4, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
If the current release branch is version X, the phrase "the previous major release." sounds to me as if it is referring to releases of X-1. Not to the last release from the current release branch, which is what I think it intends. (if it meant X-1, then we could never change the ABI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current release branch is version X, the phrase "the previous major release." sounds to me as if it is referring to releases of X-1. Not to the last release from the current release branch, which is what I think it intends.
(if it meant X-1, then we could never change the ABI)