[OMPIRBuilder][Debug] Remove unnecessary code. #156468
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the code that fixups the debug information, we handles both the debug intrinsics and debug records. With recent changes in mlir translation, we should not get debug intrinsics anymore. This means we can simplify the code by removing the handling for debug intrinsics and only focusing on debug records.
tblah
approved these changes
Sep 2, 2025
| // The location and scope of variable intrinsics and records still point to | ||
| // the parent function of the target region. Update them. | ||
| for (Instruction &I : instructions(Func)) { | ||
| if (auto *DDI = dyn_cast<llvm::DbgVariableIntrinsic>(&I)) |
There was a problem hiding this comment.
nit: do you think it is worth putting an assertion here that it is not an intrinsic to guard against these being used in the future?
I'm happy to go forward with or without the assertion.
There was a problem hiding this comment.
Thanks for the review. I have added an assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code that fix ups the debug information, we handles both the debug intrinsics and debug records. The debug intrinsics are being phased out and I recently changed mlir translation to not generate them. This means that we should not get debug intrinsics anymore and code can be simplified by removing their handling.