Skip to content

[OMPIRBuilder][Debug] Remove unnecessary code. #156468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

[OMPIRBuilder][Debug] Remove unnecessary code. #156468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3012942
[OMPIRBuilder][Debug] Remove unnecessary code.
abidh Sep 2, 2025
d00ad57
Add an assert that instruction in not a debug intrinsic.
abidh Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7382,9 +7382,8 @@ static void FixupDebugInfoForOutlinedFunction(
// The location and scope of variable intrinsics and records still point to
// the parent function of the target region. Update them.
for (Instruction &I : instructions(Func)) {
if (auto *DDI = dyn_cast<llvm::DbgVariableIntrinsic>(&I))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do you think it is worth putting an assertion here that it is not an intrinsic to guard against these being used in the future?

I'm happy to go forward with or without the assertion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I have added an assert.

UpdateDebugRecord(DDI);

assert(!isa<llvm::DbgVariableIntrinsic>(&I) &&
"Unexpected debug intrinsic");
for (DbgVariableRecord &DVR : filterDbgVars(I.getDbgRecordRange()))
UpdateDebugRecord(&DVR);
}
Expand Down
Loading