Skip to content

Mips: Force 64bit subtarget feature to be set for ABI options #157446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2025
Merged

Mips: Force 64bit subtarget feature to be set for ABI options #157446

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
776ab04
Mips: Force 64bit subtarget feature to be set for ABI options
arsenm Sep 8, 2025
f0630e8
Revert MCTargetDesc changes, backend is broken
arsenm Sep 8, 2025
c930b3b
Apply suggestions from code review
arsenm Sep 8, 2025
f74e60e
Revert other MCTargetDesc change
arsenm Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions llvm/lib/Target/Mips/MipsSubtarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,20 @@ CodeGenOptLevel MipsSubtarget::getOptLevelToEnablePostRAScheduler() const {
MipsSubtarget &
MipsSubtarget::initializeSubtargetDependencies(StringRef CPU, StringRef FS,
const TargetMachine &TM) {
StringRef CPUName = MIPS_MC::selectMipsCPU(TM.getTargetTriple(), CPU);
const Triple &TT = TM.getTargetTriple();
StringRef CPUName = MIPS_MC::selectMipsCPU(TT, CPU);

std::string FullFS;
if (getABI().ArePtrs64bit()) {
FullFS = "+ptr64";
if (!FS.empty())
FullFS = (Twine(FullFS) + "," + FS).str();
} else {
FullFS = FS.str();
}

// Parse features string.
ParseSubtargetFeatures(CPUName, /*TuneCPU*/ CPUName, FS);
ParseSubtargetFeatures(CPUName, /*TuneCPU=*/CPUName, FullFS);
// Initialize scheduling itinerary for the specified CPU.
InstrItins = getInstrItineraryForCPU(CPUName);

Expand Down