Skip to content

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Sep 10, 2025

This reverts commit 7768cca.

This is less necessary after 7f4c297

@arsenm arsenm requested a review from s-barannikov September 10, 2025 11:15
@arsenm arsenm marked this pull request as ready for review September 10, 2025 11:15
Copy link
Contributor Author

arsenm commented Sep 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Sep 10, 2025

@llvm/pr-subscribers-backend-mips

Author: Matt Arsenault (arsenm)

Changes

This reverts commit 7768cca.

This is less necessary after 7f4c297


Full diff: https://github.com/llvm/llvm-project/pull/157833.diff

1 Files Affected:

  • (modified) llvm/lib/Target/Mips/MipsSubtarget.cpp (+2-12)
diff --git a/llvm/lib/Target/Mips/MipsSubtarget.cpp b/llvm/lib/Target/Mips/MipsSubtarget.cpp
index 8b9ee7fca208e..8c4bb15a7e617 100644
--- a/llvm/lib/Target/Mips/MipsSubtarget.cpp
+++ b/llvm/lib/Target/Mips/MipsSubtarget.cpp
@@ -245,20 +245,10 @@ CodeGenOptLevel MipsSubtarget::getOptLevelToEnablePostRAScheduler() const {
 MipsSubtarget &
 MipsSubtarget::initializeSubtargetDependencies(StringRef CPU, StringRef FS,
                                                const TargetMachine &TM) {
-  const Triple &TT = TM.getTargetTriple();
-  StringRef CPUName = MIPS_MC::selectMipsCPU(TT, CPU);
-
-  std::string FullFS;
-  if (getABI().ArePtrs64bit()) {
-    FullFS = "+ptr64";
-    if (!FS.empty())
-      FullFS = (Twine(FullFS) + "," + FS).str();
-  } else {
-    FullFS = FS.str();
-  }
+  StringRef CPUName = MIPS_MC::selectMipsCPU(TM.getTargetTriple(), CPU);
 
   // Parse features string.
-  ParseSubtargetFeatures(CPUName, /*TuneCPU=*/CPUName, FullFS);
+  ParseSubtargetFeatures(CPUName, /*TuneCPU*/ CPUName, FS);
   // Initialize scheduling itinerary for the specified CPU.
   InstrItins = getInstrItineraryForCPU(CPUName);
 

@arsenm arsenm enabled auto-merge (squash) September 10, 2025 11:19
@arsenm arsenm merged commit be773c1 into main Sep 10, 2025
13 checks passed
@arsenm arsenm deleted the users/arsenm/mips/revert-157446-force-64bit-subtarget-feature branch September 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants