Skip to content

Add missing #include <cstdlib> #157840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Add missing #include <cstdlib> #157840

merged 1 commit into from
Sep 22, 2025
+1 −0

Conversation

georgthegreat
Copy link
Contributor

std::realloc is declared there

@georgthegreat
Add missing #include <cstdlib>
e34e636 
std::realloc is declared there
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Sep 10, 2025
@georgthegreat
Copy link
Contributor Author

@banach-space, could you, please, take a look? I do not see a way to invite Steve Scalpone to comments.

@banach-space
Copy link
Contributor

Thanks for submitting this!

@banach-space, could you, please, take a look? I do not see a way to invite Steve Scalpone to comments.

I don't work on Flang anymore. I've added some reviewers for your, they should be able to help.

tarunprabhu
tarunprabhu approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is this in response to an issue that was filed?

@georgthegreat
Copy link
Contributor Author

georgthegreat commented Sep 19, 2025 •
edited
Loading

Nope, this is just a built issue we have experienced in our CI (we build against libc++ with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES enabled.

This is not related to #159728

@georgthegreat
Copy link
Contributor Author

@eugeneepshteyn @tarunprabhu let's merge this.
I have one more PR to follow.

@eugeneepshteyn eugeneepshteyn merged commit bb79448 into llvm:main Sep 22, 2025
11 checks passed
@georgthegreat georgthegreat deleted the patch-2 branch September 22, 2025 13:09
@georgthegreat
Copy link
Contributor Author

@eugeneepshteyn the second tweak is #160096

SeongjaeP pushed a commit to SeongjaeP/llvm-project that referenced this pull request Oct 10, 2025
@georgthegreat @SeongjaeP
Add missing #include <cstdlib> (llvm#157840)
47f4ad5 
std::realloc is declared there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarunprabhu tarunprabhu tarunprabhu approved these changes

@eugeneepshteyn eugeneepshteyn eugeneepshteyn approved these changes

@sscalpone sscalpone Awaiting requested review from sscalpone

@kiranchandramohan kiranchandramohan Awaiting requested review from kiranchandramohan

@DavidTruby DavidTruby Awaiting requested review from DavidTruby

Assignees

No one assigned

Labels

flang Flang issues not falling into any other category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@georgthegreat @banach-space @tarunprabhu @eugeneepshteyn @llvmbot