Use CreateProcessW explicitly to improve compatibility #160096
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneepshteyn
approved these changes
Sep 22, 2025
|
@georgthegreat , are you ready for this to be merged? |
|
I am fine with this, let's do it. |
|
We still have not enabled flang in our monorepo, but this should not take long |
|
I'll merge it, since it's a good fix and it'll be ready for you once you enable the flag. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compile our monorepo with
/D_MBCSand flang-rt compilation breaks as it explicitly useswchar_t(i. e. not TCHAR).Use STARTUPINFOW / CreateProcessW method explicitly to make the code work disregarding global settings.