[Test][ASan][Sanitizer] Make symbolizer test asan and simulator only #158522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: None (thetruestblue) ChangesSimulator environments run only atos symbolizer rather than falling back to dladdr. Because sanitizer-common does not target simulators, move this test into asan and simulator only to make it predicatable test. Original change sha: 0f9bfe0 rdar://108003900 Full diff: https://github.com/llvm/llvm-project/pull/158522.diff 1 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Darwin/atos-symbolized-recover.cpp b/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
similarity index 69%
rename from compiler-rt/test/sanitizer_common/TestCases/Darwin/atos-symbolized-recover.cpp
rename to compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
index 4234e0c9a9af3..3ae6119a103d0 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Darwin/atos-symbolized-recover.cpp
+++ b/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
@@ -1,12 +1,10 @@
// Check that there is a warning when atos fails to symbolize an address
// and that atos continues symbolicating correctly after.
-// RUN: %clangxx -O0 %s -o %t
+// RUN: %clangxx_asan -O0 %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s
-
-// This test tests for undefined behavior and is leading to various failures.
-// Going to disable to unblock CI and rethink a test for this. rdar://107846128
-// UNSUPPORTED: darwin
+// REQUIRES: iossim
+// UNSUPPORTED: ubsan
void bar() {
void *invalid_addr = reinterpret_cast<void *>(0xDEADBEEF);
@@ -19,4 +17,4 @@ int main() {
return 0;
// CHECK: WARNING: atos failed to symbolize address{{.*}}
// CHECK: {{.*}}atos-symbolized-recover.cpp:[[@LINE-3]]{{.*}}
-}
+}
\ No newline at end of file
|
Simulator environments run only atos symbolizer rather than falling back to dladdr. Because sanitizer-common does not target simulators, move this test into asan and simulator only to make it predicatable test. Original change sha: 0f9bfe0 rdar://108003900
thetruestblue
force-pushed
the
blueg/symbolize-recovery
branch
from
ba0ece2 to
514fadb
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/23956 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator environments run only atos symbolizer rather than falling back to dladdr.
Because sanitizer-common does not target simulators, move this test into asan and simulator only to make it predicatable test.
Original change sha: 0f9bfe0
rdar://108003900