[RISCV] Increase GPRPair Allocation Priority #159169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This echoes what has been done for the lmul>1 vector registers, increasing priority for pairs compared to single GPRs. The changes here are not particularly large, in part due to the fact that GPRPairs are not generated in many examples, but there look to be small savings in the number of register pair copies (where instead a GPR is copied).
lenary
commented
Sep 16, 2025
Comment on lines
-12
to
-13
| ; CHECK-NEXT: mv a0, a2 | ||
| ; CHECK-NEXT: mv a1, a3 |
There was a problem hiding this comment.
I believe this is the only saving showin in this PR - swapping a GPRPair copy for a GPR copy.
I will investigate further if there are savings on our benchmarks/codebases.
|
Looks to be achieved similarly with #160084 which also looks less disruptive and more general. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This echoes what has been done for the
lmul>1vector registers, increasing priority for pairs compared to single GPRs.The changes here are not particularly large, in part due to the fact that GPRPairs are not generated in many examples, but there look to be small savings in the number of register pair copies (where instead a GPR is copied).