Reapply "RuntimeLibcalls: Use get_host_tool_path for executables used … (#159488) #159489
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
added
the
cmake
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/24227 Here is the relevant piece of the build log for the reference |
|
#159513 should fix the fuchsia failure, but is stricter than theoretically required |
|
I won't be able to look into this more until tomorrow, but this seems to have broken the RISC-V cross-build bots e.g. https://lab.llvm.org/buildbot/#/builders/87/builds/3257 |
Attempt to fix #159707 |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/15120 Here is the relevant piece of the build log for the reference |
|
What issue did this attempt to fix by adding the If building in a configuration with e.g. I guess this would require a check to see that the variables expand to something non-empty as well. Or was that what the |
Oh, sorry, I see this seems to try to address this issue! |
|
Probably don't need the target checks, really just need the executable |
Ok, right. But in which case would that be empty - IIRC most other uses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44b7abc.
Add additional if TARGET checks