cmake: Avoid using if(TARGET x AND TARGET y)

[arsenm]

This appears to not work, and the documentation only has
examples with a single target checked at a time.

[arsenm]

• cmake: Avoid using if(TARGET x AND TARGET y) #159707 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[s-barannikov]

I think the issue is that both variables are empty strings. So if(TARGET ${llc_target}) will be evaluates as if(TARGET), which I believe is invalid either.

[arsenm]

I think the issue is that both variables are empty strings. So if(TARGET ${llc_target}) will be evaluates as if(TARGET), which I believe is invalid either.

Undefined value is not a target, which works fine

[mstorsjo]

This does indeed fix the build errors - but it doesn't seem to do the right thing; if building with -DLLVM_NATIVE_TOOL_DIR=<dir>, we may have preexisting llvm-nm and llc binaries which we wanted to use; then we can just invoke ${llvm_nm_exe} right away without needing to build it. So in that way, the current if (TARGET ${llvm_nm_target}) check makes so that we don't use it at all (and don't build it either) in that case.

So what's the intended purpose of adding these TARGET checks in the first place?

[arsenm]

I was trying to fix the last build error, and figured the targets didn't exist. It turns out they do exist, just aren't executable. so yes probably should drop the target checks

[mstorsjo]

This works for me, thanks.

It's still unclear to me in which cases these variables actually would end up empty, but this looks safe (and works in my build config as well).

[asb]

Thank you, I can confirm this patch fixes my builds.