Skip to content

cmake: Avoid using if(TARGET x AND TARGET y) #159707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

cmake: Avoid using if(TARGET x AND TARGET y) #159707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dcc5c
cmake: Avoid using if(TARGET x AND TARGET y)
arsenm Sep 19, 2025
f6a90e3
Just check executables instead
arsenm Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ add_benchmark(SandboxIRBench SandboxIRBench.cpp PARTIAL_SOURCES_INTENDED)
add_benchmark(RuntimeLibcallsBench RuntimeLibcalls.cpp PARTIAL_SOURCES_INTENDED)

if(NOT LLVM_TOOL_LLVM_DRIVER_BUILD)
# TODO: Check if the tools aer in LLVM_DISTRIBUTION_COMPONENTS with
# TODO: Check if the tools are in LLVM_DISTRIBUTION_COMPONENTS with
# the driver build. Also support the driver build by invoking the
# tools through llvm-driver
get_host_tool_path(llvm-nm LLVM_NM llvm_nm_exe llvm_nm_target)
get_host_tool_path(llc LLC llc_exe llc_target)

if(TARGET ${llc_target} AND TARGET ${llvm_nm_target})
if(${llc_exe} AND ${llvm_nm_exe})
# Extract the list of symbols in a random utility as sample data.
set(SYMBOL_TEST_DATA_FILE "sample_symbol_list.txt")
set(SYMBOL_TEST_DATA_SOURCE_BINARY ${llc_exe})
Expand Down