-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[compiler-rt] Fix test ifdefs and XFAILs #160687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler-rt] Fix test ifdefs and XFAILs #160687
Conversation
This should fix failing tests that I've run into in my nightly build at https://github.com/mstorsjo/llvm-mingw/actions/runs/17993746384/job/51211649698. |
✅ With the latest revision this PR passed the C/C++ code formatter. |
This fixes the ifdefs added in e9e166e; we need to include int_lib.h first before we can expect these defines to be set. Also remove the XFAILs for aarch64 windows. As this test now became a no-op on platforms that lack CRT_HAS_128BIT or CRT_HAS_F128 (aarch64 windows lacks the latter), it no longer fails.
c7c4d11
to
d851e31
Compare
The code is new to me but after inspecting the headers, the change makes sense. I'll let @ahatanak take a look too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't realize I'd unconditionally disabled the tests. Thanks for catching the error.
Hmm, right. So this is essentially e9e166e which enabled these tests to run in these configurations (where they didn't use to run before), where they now show up as broken. I guess the best first step is to revert both this and e9e166e, and then @ahatanak can look into what's needed to make this configuration not break, if they would be relanded. |
I pushed a revert in f7e8350. |
The test also breaks the Solaris/amd64 bot:
|
The signature of the function declared in the test file is different from the builtin's signature. declaration in the test: I think we should skip the test if the return type or the argument types don't match. |
This fixes the ifdefs added in e9e166e; we need to include int_lib.h first before we can expect these defines to be set. Also remove the XFAILs for aarch64 windows. As this test now became a no-op on platforms that lack CRT_HAS_128BIT or CRT_HAS_F128 (aarch64 windows lacks the latter), it no longer fails.
This fixes the ifdefs added in e9e166e; we need to include int_lib.h first before we can expect these defines to be set. Also remove the XFAILs for aarch64 windows. As this test now became a no-op on platforms that lack CRT_HAS_128BIT or CRT_HAS_F128 (aarch64 windows lacks the latter), it no longer fails.
This fixes the ifdefs added in
e9e166e; we need to include int_lib.h first before we can expect these defines to be set.
Also remove the XFAILs for aarch64 windows. As this test now became a no-op on platforms that lack CRT_HAS_128BIT or CRT_HAS_F128 (aarch64 windows lacks the latter), it no longer fails.