Skip to content

[lldb][Linux] Fix checking of error values when attach fails #161673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+4 −2
Merged

[lldb][Linux] Fix checking of error values when attach fails #161673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2220f53
[lldb][Linux] Fix checking of error values when attach fails
DavidSpickett Oct 2, 2025
9bb644a
log error
DavidSpickett Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ static Status EnsureFDFlags(int fd, int flags) {
static llvm::Error AddPtraceScopeNote(llvm::Error original_error) {
Expected<int> ptrace_scope = GetPtraceScope();
if (auto E = ptrace_scope.takeError()) {
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "error reading value of ptrace_scope: {0}", E);
LLDB_LOG_ERROR(GetLog(POSIXLog::Process), std::move(E),
"error reading value of ptrace_scope: {0}");

// The original error is probably more interesting than not being able to
// read or interpret ptrace_scope.
Expand All @@ -230,6 +230,7 @@ static llvm::Error AddPtraceScopeNote(llvm::Error original_error) {
switch (*ptrace_scope) {
case 1:
case 2:
llvm::consumeError(std::move(original_error));
return llvm::createStringError(
std::error_code(errno, std::generic_category()),
"The current value of ptrace_scope is %d, which can cause ptrace to "
Expand All @@ -239,6 +240,7 @@ static llvm::Error AddPtraceScopeNote(llvm::Error original_error) {
"https://www.kernel.org/doc/Documentation/security/Yama.txt.",
*ptrace_scope);
case 3:
llvm::consumeError(std::move(original_error));
return llvm::createStringError(
std::error_code(errno, std::generic_category()),
"The current value of ptrace_scope is 3, which will cause ptrace to "
Expand Down
Loading