[lldb][test] Set configuration.cmake_build_type only if args.cmake_build_type is not None

[ZequanWu]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Zequan Wu (ZequanWu)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/162153.diff

1 Files Affected:

• (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+2-1)

diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index e30d5490bea22..643077405e2ea 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -300,7 +300,8 @@ def parseOptionsAndInitTestdirs():
             configuration.libcxx_include_target_dir = args.libcxx_include_target_dir
             configuration.libcxx_library_dir = args.libcxx_library_dir
 
-    configuration.cmake_build_type = args.cmake_build_type.lower()
+    if args.cmake_build_type:
+        configuration.cmake_build_type = args.cmake_build_type.lower()
 
     if args.channels:
         lldbtest_config.channels = args.channels

[DavidSpickett]

In what situation would this be None or empty? LLVM requires that you set CMAKE_BUILD_TYPE to something and even so, it would have a default value. Are you running tests against a pre-built lldb?

if args.cmake_build_type is not None

Being pedantic: being None and being falsey are 2 different things in Python. Here you mean if it's empty.

In this case it's not a big deal but it was surprising to see "is not None" in the title and then no "None" mentioned in the change.

[ZequanWu]

NVM, it's just our internal build not setting cmake_build_type.