[lldb][test] Remove class level packetLog in MockGDBServerResponder #162453
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in 1902ffd but appears to be leftover code from some older design. I can't find any code that reads packetLog via the class itself, or checks whether it is None. No tests failed on AArch64 Linux after removing it.
DavidSpickett
added
the
skip-precommit-approval
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesAdded in 1902ffd but appears to be leftover code from some older design. I can't find any code that reads packetLog via the class itself, or checks whether it is None. No tests failed on AArch64 Linux after removing it. Full diff: https://github.com/llvm/llvm-project/pull/162453.diff 1 Files Affected:
diff --git a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
index b603c35c8df09..53e991a1471fd 100644
--- a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
+++ b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
@@ -87,7 +87,6 @@ class MockGDBServerResponder:
"""
registerCount = 40
- packetLog = None
class RESPONSE_DISCONNECT:
pass
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 1902ffd but appears to be leftover code from some older design.
I can't find any code that reads packetLog via the class itself, or checks whether it is None.
No tests failed on AArch64 Linux after removing it.