[lldb] Add a missing <atomic> include. NFC. #162809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Martin Storsjö (mstorsjo) ChangesThis fixes building LLDB for mingw with libstdc++, after 8ae30a3. Previously, building errored out with errors like these: Full diff: https://github.com/llvm/llvm-project/pull/162809.diff 1 Files Affected:
diff --git a/lldb/include/lldb/Host/JSONTransport.h b/lldb/include/lldb/Host/JSONTransport.h
index 1453316e96fb4..29b40421575ac 100644
--- a/lldb/include/lldb/Host/JSONTransport.h
+++ b/lldb/include/lldb/Host/JSONTransport.h
@@ -35,6 +35,7 @@
#include <utility>
#include <variant>
#include <vector>
+#include <atomic>
#if __cplusplus >= 202002L
#include <concepts>
#endif
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This fixes building LLDB for mingw with libstdc++, after 8ae30a3. Previously, building errored out with errors like these: In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12, from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16, from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15, from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9: llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic<bool>’ 608 | std::atomic<bool> replied = {false}; | ^~~~~~~ In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33, from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78, from llvm-project/lldb/include/lldb/Host/Socket.h:12, from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13, from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12: gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic<bool>’ 162 | struct atomic; | ^~~~~~
mstorsjo
force-pushed
the
lldb-missing-atomic
branch
from
31bf67e to
8983730
Compare
DavidSpickett
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building LLDB for mingw with libstdc++, after 8ae30a3.
Previously, building errored out with errors like these: