Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm][AArch64][TargetParser][NFC] Use parseArchExtension in parseModifier. #80427

Merged

Conversation

labrinea
Copy link
Collaborator

@labrinea labrinea commented Feb 2, 2024

This allows making changes in parseArchExtension to make their way in the command line as well, not only in target attributes.

This allows making changes in parseArchExtension to make their
way in the command line as well, not only in target attributes.
@labrinea labrinea force-pushed the use-parseArchExtension-in-parseModifier branch from 64851d9 to 31efe12 Compare February 2, 2024 13:16
@DavidSpickett DavidSpickett changed the title [AArch64][TargetParser][NFC] Use parseArchExtension in parseModifier. [llvm][AArch64][TargetParser][NFC] Use parseArchExtension in parseModifier. Feb 2, 2024
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see more of this code getting centralised.

@labrinea labrinea merged commit 260fe03 into llvm:main Feb 3, 2024
4 checks passed
@labrinea labrinea deleted the use-parseArchExtension-in-parseModifier branch February 3, 2024 12:29
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
…ifier. (llvm#80427)

This allows making changes in parseArchExtension to make their way in
the command line as well, not only in target attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants