[msan] Implement support for Arm NEON vst{2,3,4} instructions #99360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
vitalybuka
reviewed
Jul 17, 2024
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 18, 2024
This adds an abridged copy of neon_vst.ll (from llvm@ff08215), but with origin tracking enabled. The test will be updated when MSan's Arm NEON support is improved (e.g., llvm#99360).
vitalybuka
pushed a commit
that referenced
this pull request
Jul 18, 2024
This adds support for vst{2,3,4}, which are not correctly handled by
handleUnknownIntrinsic/handleVector{Load,Store}Intrinsic.
vitalybuka
reviewed
Jul 18, 2024
vitalybuka
approved these changes
Jul 18, 2024
"element size has an impact on pointer alignment. Alignment to the element size generally gives better performance, and it might be a requirement of your target operating system. For example, when loading 32-bit elements, align the address of the first element to at least 32-bits." -- https://developer.arm.com/documentation/102159/0400/Load-and-store---data-structures
vitalybuka
approved these changes
Jul 18, 2024
sgundapa
pushed a commit
to sgundapa/upstream_effort
that referenced
this pull request
Jul 23, 2024
…9555) This adds an abridged copy of neon_vst.ll (from llvm@ff08215), but with origin tracking enabled. The test will be updated when MSan's Arm NEON support is improved (e.g., llvm#99360).
sgundapa
pushed a commit
to sgundapa/upstream_effort
that referenced
this pull request
Jul 23, 2024
…9360) This adds support for vst{2,3,4}, which are not correctly handled by handleUnknownIntrinsic/handleVector{Load,Store}Intrinsic. This patch also updates the tests introduced in llvm#98247 and llvm#99555 --------- Co-authored-by: Vitaly Buka <vitalybuka@gmail.com>
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This adds an abridged copy of neon_vst.ll (from ff08215), but with origin tracking enabled. The test will be updated when MSan's Arm NEON support is improved (e.g., #99360). Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251368
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary:
This adds support for vst{2,3,4}, which are not correctly handled by
handleUnknownIntrinsic/handleVector{Load,Store}Intrinsic.
This patch also updates the tests introduced in
#98247 and
#99555
---------
Co-authored-by: Vitaly Buka <vitalybuka@gmail.com>
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: https://phabricator.intern.facebook.com/D60251436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for vst{2,3,4}, which are not correctly handled by handleUnknownIntrinsic/handleVector{Load,Store}Intrinsic.
This patch also updates the tests introduced in #98247 and #99555