Skip to content

Conversation

omjavaid
Copy link
Contributor

This PR adds a new buildbot to run LLVM testsuite on windows. It adds a new builder and worker pair. The testsuite will run after the first stage build skipping the ninja check step as we cover that on other buildbots. This will primarily be the builder to test that ensures LNT and LLVM testsuite are running without regressions on windows. We will later build on it to add support for test more as our Windows hardware availability improves.

This depends on #575 and llvm/llvm-project#155226.

@DavidSpickett
Copy link
Contributor

This depends on #575 and llvm/llvm-project#155226.

And the first commit here is actually that other PR, which this is "stacked" onto. So I reviewed the second commit here.

Copy link
Contributor

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

By default LLVM flang prints a stop message in certain circumstances that
breaks some of the tests in this directory. As such we add the environment
variable NO_STOP_MESSAGE=1 to disable this behaviour.

I presume you ran these tests yourself so you'd know if the above applied. I think it's only a problem for gfortran tests.

@omjavaid omjavaid merged commit 5e65619 into llvm:main Aug 29, 2025
3 checks passed
omjavaid added a commit that referenced this pull request Sep 4, 2025
This is a follow up to #586.

Fixes 60d2141. (#576)

We forgot to fix the lnt path to work on both windows and linux.

On Windows, it's Scripts/lnt, on Linux it's bin/lnt.
vvereschaka pushed a commit to vvereschaka/llvm-zorg that referenced this pull request Sep 25, 2025
This PR adds a new buildbot to run LLVM testsuite on windows. It adds a
new builder and worker pair. The testsuite will run after the first
stage build skipping the ninja check step as we cover that on other
buildbots. This will primarily be the builder to test that ensures LNT
and LLVM testsuite are running without regressions on windows. We will
later build on it to add support for test more as our Windows hardware
availability improves.

This depends on llvm#575 and llvm/llvm-project#155226.
vvereschaka pushed a commit to vvereschaka/llvm-zorg that referenced this pull request Sep 25, 2025
This is a follow up to llvm#586.

Fixes 60d2141. (llvm#576)

We forgot to fix the lnt path to work on both windows and linux.

On Windows, it's Scripts/lnt, on Linux it's bin/lnt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants