Address small downstream build issues (#4289)

Two issues seemed to block an integrate downstream with IREE:
iree-org/iree#21628

1. Addresses an unused variable for release builds (and fixes a typo in
the check 2->3).
2. Adds missing custom build methods for two `TMTensor` ops. (I'm not
sure why this hasn't caused a failure in the past).

Signed-off-by: zjgarvey <zjgarvey@gmail.com>

Author: zjgarvey

include/torch-mlir-dialects/Dialect/TMTensor/IR/TMTensorOps.td

@@ -62,7 +62,9 @@ def TMTensor_ScanOp : TMTensor_Op<"scan",
 
   let builders = [
     OpBuilder<(ins "ValueRange":$inputs, "ValueRange":$outputs,
-      CArg<"int64_t", "0">:$dimension, CArg<"bool", "true">:$inclusive)>
+      CArg<"int64_t", "0">:$dimension, CArg<"bool", "true">:$inclusive), [{
+        build($_builder, $_state, TypeRange(outputs), inputs, outputs, dimension, inclusive);
+      }]>
   ];
 
   let results = (outs Variadic<AnyRankedTensor>:$results);
@@ -267,7 +269,9 @@ def TMTensor_AttentionOp : TMTensor_Op<"attention",
   );
 
   let builders = [
-    OpBuilder<(ins "ValueRange":$inputs, "ValueRange":$outputs)>
+    OpBuilder<(ins "ValueRange":$inputs, "ValueRange":$outputs), [{
+        build($_builder, $_state, TypeRange(outputs), inputs, outputs);
+    }]>
   ];
 
   let results = (outs Variadic<AnyRankedTensor>:$result);

lib/Conversion/TorchToLinalg/TensorConstructors.cpp

@@ -284,8 +284,8 @@ class ConvertAtenReplicationPad3dOp
     Location loc = op->getLoc();
     Value input = adaptor.getSelf();
     auto inputType = llvm::cast<RankedTensorType>(input.getType());
-    int64_t inputRank = inputType.getRank();
-    assert(inputRank >= 2 && "Not enough input dimensions");
+    [[maybe_unused]] int64_t inputRank = inputType.getRank();
+    assert(inputRank >= 3 && "Not enough input dimensions");
 
     SmallVector<int64_t> padInts;
     if (!matchPattern(op.getPadding(), m_TorchListOfConstantInts(padInts)))

lib/Conversion/TorchToTMTensor/TorchToTMTensor.cpp

@@ -236,12 +236,9 @@ static Value createTMTensorScanOp(
     int64_t dim, bool inclusive,
     function_ref<void(OpBuilder &, Location, Value, Value)> bodyBuild) {
   auto inputType = cast<RankedTensorType>(input.getType());
-  auto accType = cast<RankedTensorType>(accumulator.getType());
   Type elementType = inputType.getElementType();
   auto scanOp = b.create<TMTensor::ScanOp>(
-      loc, TypeRange{inputType, accType}, input,
-      ValueRange{output, accumulator}, b.getI64IntegerAttr(dim),
-      b.getBoolAttr(inclusive));
+      loc, ValueRange{input}, ValueRange{output, accumulator}, dim, inclusive);
 
   Region &scanOpRegion = scanOp.getRegion();
   auto &scanOpBlock = scanOpRegion.emplaceBlock();