Skip to content

Conversation

pon
Copy link
Contributor

@pon pon commented Jan 17, 2015

@lob/api-engineering-team

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh does this delete the api version from the test above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - it was causing all tests before to succeed and all the ones following to fail

@leore
Copy link
Contributor

leore commented Jan 17, 2015

LGTM

1 similar comment
@mgartner
Copy link
Contributor

LGTM

pon added a commit that referenced this pull request Jan 18, 2015
Fixed small test issues to get build working
@pon pon merged commit edd39a5 into master Jan 18, 2015
@pon pon deleted the upgrade-version branch January 18, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants