Skip to content

Fixed small test issues to get build working #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2015
Merged

Fixed small test issues to get build working #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eafc213
updated version
pon Jan 10, 2015
38bd794
Merge branch 'master' of https://github.com/lob/lob-python
pon Jan 17, 2015
bec057a
fixed up tets
pon Jan 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lob/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = '2.10'
VERSION = '2.11'
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

setup (
name = 'lob',
version = '2.10',
version = '2.11',
author = 'Lob',
author_email = 'support@lob.com',
packages = ['lob'],
Expand Down
3 changes: 3 additions & 0 deletions tests/test_lob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ def test_bad_auth(self):

def test_set_version(self):
self.assertEqual(lob.api_version, 'apiVersion')

def tearDown(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh does this delete the api version from the test above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - it was causing all tests before to succeed and all the ones following to fail

del lob.api_version
2 changes: 1 addition & 1 deletion tests/test_postcard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def test_create_postcard_inline(self):
'address_zip': '94107',
'address_state': 'CA'
},
front = 'https://www.lob.com/test.pdf',
front = 'https://s3-us-west-2.amazonaws.com/lob-assets/test.pdf',
message = 'Hello'
)
self.assertEqual(postcard.to_address.name, 'Lob1')
Expand Down