docker-rotate 2.0

[zvikagart]

Greetings Friends!

I've made the following changes to the package:

• update and simplify container cleanup logic
• refactor image and container cleanup to own sub commands
• generalize image selection

More details inside.

The changes are breaking so I versioned it 2.0.

[zvikagart]

Only exited containers or containers that have been created but not started are considered for removal.

Note that I removed the support for data containers.
In latest docker versions data volumes are first class objects and should be created with docker volume command instead of creating data containers. This removes the guesswork we had here before.

[zvikagart]

Thanks for merging.
Can you push this version to pypi? I don't see it there
https://pypi.python.org/pypi/dockerrotate

[wheremiah]

Looks like an auth error when travis is pushing to pypi.
HTTPError: 401 Client Error: You must be identified to edit package information for url: https://pypi.python.org/pypi
I will try to take a look at what is causing the error tomorrow.

[wheremiah]

Hey Zvika, I am not sure why this is failing to push to pypi. We are getting an auth error, but I see other builds that look like they were successfully pushed with the same creds. I'm gonna have to look a little more.

[zvikagart]

I see in .travis.yml file that Jesse's credentials are used to push to pypi
might be the reason

On Tue, Mar 8, 2016 at 10:19 AM wheremiah notifications@github.com wrote:

Hey Zvika, I am not sure why this is failing to push to pypi. We are
getting an auth error, but I see other builds that look like they were
successfully pushed with the same creds. I'm gonna have to look a little
more.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

[wheremiah]

I thought so too, but those still worked for mockredispy. We're gonna need
to get that updated in any case though.

On Tue, Mar 8, 2016 at 1:52 AM, zvikagart notifications@github.com wrote:

I see in .travis.yml file that Jesse's credentials are used to push to pypi
might be the reason

On Tue, Mar 8, 2016 at 10:19 AM wheremiah notifications@github.com
wrote:

Hey Zvika, I am not sure why this is failing to push to pypi. We are
getting an auth error, but I see other builds that look like they were
successfully pushed with the same creds. I'm gonna have to look a little
more.

—
Reply to this email directly or view it on GitHub
<
#8 (comment)

.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

[wheremiah]

Hey Zvika, this should be available on pypi now. The version is 2.0.1. I guess it was related to the credentials. Lemme know if you have any trouble, and thanks for the updates to docker-rotate!

[zvikagart]

Great. Thanks.