improvement: Adds timestamp to messages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm36
changed the title
dm36
force-pushed
the
dmadhok/LOG-7156
branch
2 times, most recently
from
8e67182
to
5f081f1
Compare
dm36
requested review from
darinspivey,
smusali,
a team,
zeldanut and
jakedipity
mdeltito
requested changes
Sep 9, 2020
dm36
force-pushed
the
dmadhok/LOG-7156
branch
4 times, most recently
from
2b7ff22
to
8ef23dc
Compare
mdeltito
requested changes
Sep 10, 2020
|
also note that code coverage is being published, you can check it in CircleCI artifacts: https://98-268886384-gh.circle-artifacts.com/0/tmp/artifacts/coverage.html#file2 (you will see there is a new uncovered line in this PR) |
dm36
force-pushed
the
dmadhok/LOG-7156
branch
2 times, most recently
from
4d3c07c
to
680a50f
Compare
dm36
commented
Sep 11, 2020
dm36
commented
Sep 11, 2020
dm36
force-pushed
the
dmadhok/LOG-7156
branch
from
680a50f
to
2222ecd
Compare
mdeltito
reviewed
Sep 11, 2020
dm36
force-pushed
the
dmadhok/LOG-7156
branch
from
2222ecd
to
2b32a47
Compare
jakedipity
requested changes
Sep 14, 2020
dm36
force-pushed
the
dmadhok/LOG-7156
branch
from
2b32a47
to
b1f926d
Compare
smusali
reviewed
Sep 14, 2020
smusali
reviewed
Sep 14, 2020
Includes a timestamp for each message/line that flows through the client. Allows the user to provide their own timestamp through Options- and if the timestamp is not provided- the value is defaulted. Semver: Patch Ref: LOG-7156
dm36
force-pushed
the
dmadhok/LOG-7156
branch
from
b1f926d
to
7f8ffc4
Compare
mdeltito
approved these changes
Sep 14, 2020
jakedipity
approved these changes
Sep 15, 2020
| if timestamp.IsZero() { | ||
| timestamp = time.Now() | ||
| } | ||
| line.Timestamp = timestamp.UnixNano() / int64(time.Millisecond) |
There was a problem hiding this comment.
I was also going to originally mention that this logic is a bit confusing to read at first. It's mostly an issue with the variable names not providing enough context. My understanding is that the constant time.Millisecond is the Duration of 1ms. Duration is measured in nanoseconds so time.Millisecond is the number of nanoseconds in 1 millisecond. That's why the math above works.
Might be worthwhile to drop a comment about it. Not necessary, gonna approve regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement: Adds timestamp to messages
Includes a timestamp for each message/line that flows through the client.
Allows the user to provide their own timestamp through Options- and if the timestamp is not provided- a default value is used.
Semver: Patch
Ref: LOG-7156