Skip to content

fix: use new CDN for errorcodes repository #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2023
Merged

fix: use new CDN for errorcodes repository #1320

merged 3 commits into from
May 31, 2023

Conversation

@jkaster
Copy link

@jkaster jkaster commented May 31, 2023

using https://static-a.cdn.looker.app instead of the old CDN

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

APIX Tests

    1 files    88 suites   9m 36s ⏱️
418 tests 392 ✔️ 26 💤 0 ❌
440 runs  414 ✔️ 26 💤 0 ❌

Results for commit 962b763.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Typescript Tests

    6 files    56 suites   10m 51s ⏱️
200 tests 196 ✔️   4 💤 0 ❌
494 runs  478 ✔️ 16 💤 0 ❌

Results for commit 962b763.

zeckertG
zeckertG requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@zeckertG zeckertG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one quick change

packages/sdk-rtl/src/errorDoc.spec.ts Outdated
'https://marketplace-api.looker.com/errorcodes/live/login_404.md',
'login',
],
['https://static-a.cdn.looker.app/errorcodes/live/login_404.md', 'login'],
Copy link
Contributor

@zeckertG zeckertG May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove /live from this path. https://static-a.cdn.looker.app/errorcodes/login_404.md works!

Copy link
Author

@jkaster jkaster May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the /live path could have been anything. I was testing to make sure localized error docs would also resolve to a method name.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

APIX Tests

    1 files    88 suites   6m 52s ⏱️
418 tests 392 ✔️ 26 💤 0 ❌
440 runs  414 ✔️ 26 💤 0 ❌

Results for commit 6779c9a.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Typescript Tests

    6 files    56 suites   9m 42s ⏱️
200 tests 196 ✔️   4 💤 0 ❌
494 runs  478 ✔️ 16 💤 0 ❌

Results for commit 6779c9a.

@jkaster jkaster merged commit df40441 into main May 31, 2023
@jkaster jkaster deleted the jk/new_cdn branch May 31, 2023 17:00
Merged
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeckertG zeckertG zeckertG approved these changes

@bryans99 bryans99 Awaiting requested review from bryans99

@josephaxisa josephaxisa Awaiting requested review from josephaxisa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkaster @zeckertG