fix(Transport): Disable automatic User Agent Suffix #1420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tjbanghart @jkaster can you review this please? This change fixes our application's integration with Looker instances. |
daniel-lopes-optimizely
referenced
this pull request
Jan 8, 2024
* Replace ktor with Google Java HTTP client * Remove ktor and clean up methods * Disable cookie management for Apache transport
tjbanghart
approved these changes
Jan 9, 2024
Contributor
tjbanghart
left a comment
tjbanghart
left a comment
There was a problem hiding this comment.
LGTM @jkaster can we run CI on this?
Contributor
Author
|
@tjbanghart @jkaster can we merge this soon? The current code breaks contract with cookieless embedding. |
drstrangelooker
pushed a commit
that referenced
this pull request
Jan 24, 2024
…1423) CLONE OF #1420 This small fix to the Kotlin Transport code, disables automatic User Agent suffixing by the Google-HTTP-Java library. Looker is very specific about User Agent names, especially when using cookieless embedding sessions and this change will fix the contract violation between this code and the API. Related to this [discussion](5407e63#commitcomment-136501445). Co-authored-by: Daniel Lopes <daniel.lopes@optimizely.com>
Merged
Contributor
|
Merged in aa6c173 Thank you for the PR! |
jeremytchang
pushed a commit
that referenced
this pull request
Feb 3, 2024
🤖 I have created a release *beep* *boop*
---
<details><summary>@looker/api-explorer: 0.9.56</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-utils bumped from 0.1.32 to 0.1.33
* @looker/run-it bumped from 0.9.55 to 0.9.56
* @looker/sdk bumped from 23.20.1 to 24.0.0
* devDependencies
* @looker/sdk-codegen-scripts bumped from 21.5.12 to 21.5.13
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/extension-api-explorer: 22.21.13</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/api-explorer bumped from 0.9.55 to 0.9.56
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
* @looker/extension-utils bumped from 0.1.32 to 0.1.33
* @looker/run-it bumped from 0.9.55 to 0.9.56
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/extension-playground: 1.0.13</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>extension-tile-playground: 1.1.0</summary>
##
[1.1.0](extension-tile-playground-v1.0.0...extension-tile-playground-v1.1.0)
(2024-02-03)
### Features
* Allow for setting vis config in extensions
([3fbe8fd](3fbe8fd))
* Allow for setting vis config in extensions
([#1394](#1394))
([3ea3cfc](3ea3cfc))
### Bug Fixes
* sync up package versions
([#1356](#1356))
([351a15d](351a15d))
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/extension-utils: 0.1.33</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/hackathon: 22.21.15</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/extension-sdk-react bumped from 23.20.1 to 24.0.0
* @looker/extension-utils bumped from 0.1.32 to 0.1.33
* @looker/sdk bumped from 23.20.1 to 24.0.0
* @looker/wholly-artifact bumped from 0.1.13 to 0.1.14
</details>
<details><summary>@looker/run-it: 0.9.56</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-utils bumped from 0.1.32 to 0.1.33
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/sdk-codegen-scripts: 21.5.13</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/wholly-artifact: 0.1.14</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
* devDependencies
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>@looker/wholly-sheet: 0.5.52</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
* devDependencies
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>sdk-codegen-all: 24.0.0</summary>
##
[24.0.0](sdk-codegen-all-v23.21.0...sdk-codegen-all-v24.0.0)
(2024-02-03)
### Features
* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))
### Bug Fixes
* **Transport:** Disable automatic User Agent Suffix [clone of
[#1420](#1420)]
([#1423](#1423))
([aa6c173](aa6c173))
</details>
<details><summary>looker_sdk: 24.0.0</summary>
##
[24.0.0](looker_sdk-v23.20.1...looker_sdk-v24.0.0)
(2024-02-03)
### Features
* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))
</details>
<details><summary>embed-components: 24.0.0</summary>
##
[24.0.0](embed-components-v23.20.1...embed-components-v24.0.0)
(2024-02-03)
### Miscellaneous Chores
* **embed-components:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/embed-services bumped from 23.20.1 to 24.0.0
* @looker/sdk bumped from 23.20.1 to 24.0.0
* devDependencies
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>embed-services: 24.0.0</summary>
##
[24.0.0](embed-services-v23.20.1...embed-services-v24.0.0)
(2024-02-03)
### Miscellaneous Chores
* **embed-services:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
* devDependencies
* @looker/sdk-node bumped from 23.20.1 to 24.0.0
</details>
<details><summary>extension-sdk: 24.0.0</summary>
##
[24.0.0](extension-sdk-v23.20.1...extension-sdk-v24.0.0)
(2024-02-03)
### Miscellaneous Chores
* **extension-sdk:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>extension-sdk-react: 24.0.0</summary>
##
[24.0.0](extension-sdk-react-v23.20.1...extension-sdk-react-v24.0.0)
(2024-02-03)
### Miscellaneous Chores
* **extension-sdk-react:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 23.20.1 to 24.0.0
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
<details><summary>sdk: 24.0.0</summary>
##
[24.0.0](sdk-v23.20.1...sdk-v24.0.0)
(2024-02-03)
### Features
* generate SDKs for Looker 24.0
([#1426](#1426))
([8c42be7](8c42be7))
</details>
<details><summary>sdk-node: 24.0.0</summary>
##
[24.0.0](sdk-node-v23.20.1...sdk-node-v24.0.0)
(2024-02-03)
### Miscellaneous Chores
* **sdk-node:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 23.20.1 to 24.0.0
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix to the Kotlin Transport code, disables automatic User Agent suffixing by the Google-HTTP-Java library.
Looker is very specific about User Agent names, especially when using cookieless embedding sessions and this change will fix the contract violation between this code and the API.
Related to this discussion.