-
Notifications
You must be signed in to change notification settings - Fork 198
feat: generate SDKs for Looker 25.18 #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release-As: 25.18.0
Summary of ChangesHello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant update to the Looker SDKs, advancing them to version 25.18. The changes primarily focus on expanding API capabilities with new methods for searching LookML dashboards, managing service accounts, and checking integration hub health. It also introduces several new data models and fields, enhancing existing functionalities and providing more granular control and information, particularly for users operating within Looker (Google Cloud core) environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Looker SDKs to version 25.18, introducing new API methods and models across C#, Go, Kotlin, Python, Swift, and TypeScript. The changes are mostly auto-generated and look good overall. My review focuses on improving the code generation quality by pointing out some formatting and consistency issues in the C#, Go, and Swift SDKs to enhance readability and maintainability.
| { | ||
| return await AuthRequest<DashboardLookml, Exception>(HttpMethod.Get, "/dashboards/lookml/search", new Values { | ||
| { "folder_id", folder_id }, | ||
| { "title", title }, | ||
| { "content_favorite_id", content_favorite_id }, | ||
| { "fields", fields }, | ||
| { "limit", limit }, | ||
| { "offset", offset }, | ||
| { "sorts", sorts }},null,options); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this method body is incorrect. The opening brace { is on a new line by itself, and the indentation of the method's contents is inconsistent. This reduces code readability. This formatting issue is present in other newly added methods as well, such as get_integration_hub_health and update_service_account.
{
return await AuthRequest<DashboardLookml, Exception>(HttpMethod.Get, "/dashboards/lookml/search", new Values {
{ "folder_id", folder_id },
{ "title", title },
{ "content_favorite_id", content_favorite_id },
{ "fields", fields },
{ "limit", limit },
{ "offset", offset },
{ "sorts", sorts }},null,options);
}| public bool? enable_starttls_auto { get; set; } = null; | ||
| /// <summary>TLS version selected Valid values are: "TLSv1_1", "SSLv23", "TLSv1_2".</summary> | ||
| [JsonConverter(typeof(StringEnumConverter))] | ||
| public SslVersion? ssl_version { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| func (l *LookerSDK) SearchLookmlDashboards(request RequestSearchLookmlDashboards, | ||
| options *rtl.ApiSettings) (DashboardLookml, error) { | ||
| var result DashboardLookml | ||
| err := l.AuthSession.Do(&result, "GET", "/4.0", "/dashboards/lookml/search", map[string]interface{}{"folder_id": request.FolderId, "title": request.Title, "content_favorite_id": request.ContentFavoriteId, "fields": request.Fields, "limit": request.Limit, "offset": request.Offset, "sorts": request.Sorts}, nil, options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| let result: SDKResponse<DashboardLookml, SDKError> = self.get("/dashboards/lookml/search", | ||
| ["folder_id": folder_id, "title": title, "content_favorite_id": content_favorite_id, "fields": fields, "limit": limit, "offset": offset, "sorts": sorts], nil, options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| options: ITransportSettings? = nil | ||
| ) -> SDKResponse<Data, SDKError> { | ||
| let result: SDKResponse<Data, SDKError> = self.get("/dashboards/lookml/search", | ||
| ["folder_id": folder_id, "title": title, "content_favorite_id": content_favorite_id, "fields": fields, "limit": limit, "offset": offset, "sorts": sorts], nil, options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go Tests 6 files 6 suites 2m 16s ⏱️ Results for commit a3b5dbd. |
🤖 I have created a release *beep* *boop*
---
<details><summary>@looker/api-explorer: 0.9.79</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/code-editor bumped from 0.1.45 to 0.1.46
* @looker/extension-utils bumped from 0.1.55 to 0.1.56
* @looker/run-it bumped from 0.9.78 to 0.9.79
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk-codegen bumped from 21.10.0 to 21.10.1
* devDependencies
* @looker/sdk-codegen-scripts bumped from 21.5.35 to 21.5.36
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/code-editor: 0.1.46</summary>
### Dependencies
* The following workspace dependencies were updated
* devDependencies
* @looker/sdk-codegen bumped from 21.10.0 to 21.10.1
</details>
<details><summary>@looker/extension-api-explorer: 22.21.36</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/api-explorer bumped from 0.9.78 to 0.9.79
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/extension-sdk-react bumped from 25.16.0 to 25.18.0
* @looker/extension-utils bumped from 0.1.55 to 0.1.56
* @looker/run-it bumped from 0.9.78 to 0.9.79
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk-codegen bumped from 21.10.0 to 21.10.1
</details>
<details><summary>@looker/extension-playground: 1.0.36</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/extension-sdk-react bumped from 25.16.0 to 25.18.0
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/extension-tile-playground: 1.1.23</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/extension-sdk-react bumped from 25.16.0 to 25.18.0
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/extension-utils: 0.1.56</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/code-editor bumped from 0.1.45 to 0.1.46
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/extension-sdk-react bumped from 25.16.0 to 25.18.0
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/hackathon: 22.21.38</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/code-editor bumped from 0.1.45 to 0.1.46
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/extension-sdk-react bumped from 25.16.0 to 25.18.0
* @looker/extension-utils bumped from 0.1.55 to 0.1.56
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/wholly-artifact bumped from 0.1.36 to 0.1.37
</details>
<details><summary>@looker/run-it: 0.9.79</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/code-editor bumped from 0.1.45 to 0.1.46
* @looker/extension-utils bumped from 0.1.55 to 0.1.56
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk-codegen bumped from 21.10.0 to 21.10.1
* @looker/sdk-codegen-utils bumped from 21.0.25 to 21.0.26
</details>
<details><summary>@looker/sdk-codegen: 21.10.1</summary>
### Dependencies
* The following workspace dependencies were updated
* devDependencies
* @looker/sdk-codegen-utils bumped from 21.0.25 to 21.0.26
</details>
<details><summary>@looker/sdk-codegen-scripts: 21.5.36</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk-codegen bumped from 21.10.0 to 21.10.1
* @looker/sdk-codegen-utils bumped from 21.0.25 to 21.0.26
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/sdk-codegen-utils: 21.0.26</summary>
### Dependencies
* The following workspace dependencies were updated
* devDependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/wholly-artifact: 0.1.37</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
* devDependencies
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>@looker/wholly-sheet: 0.5.75</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
* devDependencies
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>sdk-codegen-all: 25.18.0</summary>
##
[25.18.0](sdk-codegen-all-v25.16.0...sdk-codegen-all-v25.18.0)
(2025-10-28)
### Features
* generate SDKs for Looker 25.18
([#1609](#1609))
([f3ce99d](f3ce99d))
</details>
<details><summary>looker_sdk: 25.18.0</summary>
##
[25.18.0](looker_sdk-v25.16.0...looker_sdk-v25.18.0)
(2025-10-28)
### Features
* generate SDKs for Looker 25.18
([#1609](#1609))
([f3ce99d](f3ce99d))
</details>
<details><summary>embed-components: 25.18.0</summary>
##
[25.18.0](embed-components-v25.16.0...embed-components-v25.18.0)
(2025-10-28)
### Miscellaneous Chores
* **embed-components:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/embed-services bumped from 25.16.0 to 25.18.0
* @looker/sdk bumped from 25.16.0 to 25.18.0
* devDependencies
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>embed-services: 25.18.0</summary>
##
[25.18.0](embed-services-v25.16.0...embed-services-v25.18.0)
(2025-10-28)
### Miscellaneous Chores
* **embed-services:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
* devDependencies
* @looker/sdk-node bumped from 25.16.0 to 25.18.0
</details>
<details><summary>extension-sdk: 25.18.0</summary>
##
[25.18.0](extension-sdk-v25.16.0...extension-sdk-v25.18.0)
(2025-10-28)
### Miscellaneous Chores
* **extension-sdk:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
<details><summary>extension-sdk-react: 25.18.0</summary>
##
[25.18.0](extension-sdk-react-v25.16.0...extension-sdk-react-v25.18.0)
(2025-10-28)
### Miscellaneous Chores
* **extension-sdk-react:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/extension-sdk bumped from 25.16.0 to 25.18.0
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
<details><summary>sdk: 25.18.0</summary>
##
[25.18.0](sdk-v25.16.0...sdk-v25.18.0)
(2025-10-28)
### Features
* generate SDKs for Looker 25.18
([#1609](#1609))
([f3ce99d](f3ce99d))
</details>
<details><summary>sdk-node: 25.18.0</summary>
##
[25.18.0](sdk-node-v25.16.0...sdk-node-v25.18.0)
(2025-10-28)
### Miscellaneous Chores
* **sdk-node:** Synchronize undefined versions
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @looker/sdk bumped from 25.16.0 to 25.18.0
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Release-As: 25.18.0