Skip to content

Conversation

tjbanghart
Copy link
Contributor

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

  • 👆 Make sure your pull request title follows Pull Request Title Guidelines from our Contribution guide
  • 👉 Don't forget to replace these instructions with your ✨awesome✨ description of what this change actually does. Additionally, it's great to include context on how it works and why the change was needed.
  • 👇 Edit "Developer Checklist" to reflect items relevant to this PR (and try to make sure to check everything off before asking for review)

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #1386 🦕

@tjbanghart tjbanghart changed the title replace ini4j with Apache Commons Configuration Replace ini4j with apache-commons-configuration Oct 19, 2023
@tjbanghart tjbanghart requested a review from jkaster October 19, 2023 20:28
@tjbanghart tjbanghart force-pushed the tjbanghart/remove-ini4j branch from 289438e to 8f8e9e1 Compare October 19, 2023 20:31
@tjbanghart tjbanghart merged commit 926cab5 into main Oct 20, 2023
@tjbanghart tjbanghart deleted the tjbanghart/remove-ini4j branch October 20, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kotlin/Java]Replace ini4j with apache-commons-configuration

2 participants