Skip to content

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Dec 5, 2022

This PR will restrict the relations in openapi spec by using enum.

Signed-off-by: Muhammad Aaqil aaqilniz@yahoo.com

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3620840254

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 55.264%

Totals Coverage Status
Change from base Build 3616204764: 0.2%
Covered Lines: 9520
Relevant Lines: 12285

💛 - Coveralls

Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Some tests would be good to prevent regression, but I'm ok to merge it as-is.

This PR will restrict the relations in openapi spec by using enum.

Signed-off-by: Muhammad Aaqil <aaqilniz@yahoo.com>
@aaqilniz aaqilniz force-pushed the feat/openapi-relation branch from a1925f4 to 58ac19b Compare December 9, 2022 13:25
@aaqilniz
Copy link
Contributor Author

aaqilniz commented Dec 9, 2022

@achrinza. I have added a test for the change. Please have a look at it.

@aaqilniz
Copy link
Contributor Author

aaqilniz commented Dec 9, 2022

@achrinza All checks have successfully passed. Is the PR good to be merged?

@achrinza achrinza merged commit 46fb08e into loopbackio:master Dec 9, 2022
@aaqilniz aaqilniz deleted the feat/openapi-relation branch August 24, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants