Fix race conditions in Faraday::Utils::Headers #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday::Utils::Headers
uses a sharedKeyMap
hash to cache symbol -> string mappings of HTTP header names. When multiple threads are writing to the cache, race conditions may occur, as theHash
class is not thread-safe in Ruby.This commit adds a mutex to synchronize writes to the
KeyMap
hash. This was enough to remove the race conditions I was seeing in my multi-threaded app running on Rubinius.