median filter #1161
Merged
median filter #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
requested changes
Mar 16, 2018
src/pipeline.cc
Outdated
|
|
||
| // Median - must happen before blurring, due to the utility of blurring after thresholding | ||
| if (shouldApplyMedian) { | ||
| image = sharp::Median(image, baton->medianSize); |
There was a problem hiding this comment.
This can probably use libvips' median operation, something like:
if (baton->medianSize > 0) {
image = image.median(baton->medianSize);
}There was a problem hiding this comment.
Done, although I am missing something... do we still need
VImage Median(VImage image, int const m) {
return image.rank(m, m, (m*m)/2);
}
in src/operations.cc ?
src/pipeline.cc
Outdated
| @@ -1194,6 +1199,7 @@ NAN_METHOD(pipeline) { | |||
| baton->flatten = AttrTo<bool>(options, "flatten"); | |||
| baton->negate = AttrTo<bool>(options, "negate"); | |||
| baton->blurSigma = AttrTo<double>(options, "blurSigma"); | |||
| baton->medianSize = AttrTo<double>(options, "medianSize"); | |||
There was a problem hiding this comment.
The size is integral so uint32_t would make a better type here.
There was a problem hiding this comment.
fixed! sorry - again - for the copy-paste.
BiancoA
commented
Mar 17, 2018
src/operations.cc
Outdated
| /* | ||
| * Median filter with mask size m | ||
| */ | ||
| VImage Median(VImage image, int const m) { |
There was a problem hiding this comment.
here, do we still need this?
There was a problem hiding this comment.
Good spot, yes, this code is no longer used. Please go ahead and remove it and its definition in the header file, thank you.
lovell
approved these changes
Mar 17, 2018
|
Thank you, this will be in v0.20.1. |
lovell
added a commit
that referenced
this pull request
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #1159 I added the median filter using vips_rank()