Fix wavedrom versions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure to pickup the correct versions for wavedrom.
|
This fixes the wavedrom bug, that was solved by the major rewrite. This will be part of the next release which is ETA in a couple of days. Until then, manually pick up the release candidate. Fixes #24 |
|
PDF still cannot build, but this is unrelated to this issue: It seems that sphinx emits incorrect latex code for images inside a note/warning. A simple workaround is to move the wavedrom image out of the warning box, but I can also have a look into the sphinx generation part. |
|
Thanks Stefan! |
imphil
approved these changes
May 15, 2019
taoliug
added a commit
to taoliug/ibex
that referenced
this pull request
Jul 15, 2019
Update code from upstream repository https://github.com/google/riscv- dv to revision 2e5a40145a367ac3b04f78fee02c5011022719fd * Merge pull request lowRISC#36 from google/dev (taoliug) * Add basic debug mode support (Tao Liu)
taoliug
added a commit
that referenced
this pull request
Jul 15, 2019
Update code from upstream repository https://github.com/google/riscv- dv to revision 2e5a40145a367ac3b04f78fee02c5011022719fd * Merge pull request #36 from google/dev (taoliug) * Add basic debug mode support (Tao Liu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure to pickup the correct versions for wavedrom.