[dv,top_earlgrey] Fix pwrmgr_rstmgr_sva_if bind for top #24007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matutem
force-pushed
the
pwrmgr_main_power_glitch
branch
from
f9ad59a
to
18d77ca
Compare
matutem
requested review from
hcallahan-lowrisc and
andreaskurth
and removed request for
a team
matutem
force-pushed
the
pwrmgr_main_power_glitch
branch
6 times, most recently
from
3d313cb
to
e44f7e9
Compare
2 tasks
andreaskurth
approved these changes
Jul 16, 2024
| name: "lowrisc:dv:rstmgr_unit_only_sva:0.1" | ||
| description: "RSTMGR assertion modules not suitable for chip level and bind file." | ||
| name: "lowrisc:dv:pwrmgr_unit_only_sva:0.1" | ||
| gdescription: "PWRMGR assertion interfaces not suitable for chip level bind file." |
There was a problem hiding this comment.
gdescription is probably a typo?
Suggested change
| gdescription: "PWRMGR assertion interfaces not suitable for chip level bind file." | |
| description: "PWRMGR assertion interfaces not suitable for chip level bind file." |
There was a problem hiding this comment.
This seems to cause the failure of the in-depth lint CI check
matutem
force-pushed
the
pwrmgr_main_power_glitch
branch
from
e44f7e9
to
8200a21
Compare
The assertions pwrmgr_rstmgr_sva_if need to be disabled when either aon or main_pok are inactive. It is more reliable to bind them to rstmgr for top-level simulations. This PR does that and connects rst_slow_ni to &rst_por_aon_n, since rst_por_aon_n is 2-bit wide (one per domain), and captures the rstmgr behavior more accurately. This also removes the rstmgr_unit_only* files for simplicity. Fixes lowRISC#23961 Signed-off-by: Guillermo Maturana <maturana@opentitan.org>
matutem
force-pushed
the
pwrmgr_main_power_glitch
branch
from
8200a21
to
f1b4b68
Compare
|
The failures are unrelated. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions pwrmgr_rstmgr_sva_if need to be disabled when either aon or main_pok are inactive. It is more reliable to bind them to rstmgr for top-level simulations. This PR does that and connects &rst_por_aon_n to rst_slow_ni, since rst_por_aon_n is 2-bit wide (one per domain), and captures the rstmgr behavior more accurately.
Fixes #23961