Repository navigation
Factory 0.4.6
Factory 0.4.6 fixes a plan that could never be reviewed again. The 5-round design review cap counted every round a task had ever had. A plan changed after its review passed, for example because your answers sent it back, would have been round 6, so no round started. The Builder stayed held behind a plan nobody had read, and the Planner was told the plan was ready.
On one factory, three plans in a row were posted after a passed review, and none of them got a round.
What changes
- The cap counts one review. A review ends when a round passes it, when its findings are all settled, or when you accept the plan. A plan changed after that starts a new review with every lens, and gets up to 5 rounds of its own. Rounds keep their numbers across the task, so the new review's first round can be round 6.
- Accepting at the cap ends the review. When you accept a plan that reached the cap, the next plan your answers send back gets a new review, instead of hitting the cap again.
- A new review says so, on its first round: "A new review: the last one ended after round 5, on an earlier plan."
- The Planner hears what happened.
bb factory plan-readynow adds "Design review round 6 started…", or "No design review round started: this review has had 5 rounds…". - At the cap, the factory says why. Assigning a Builder is refused with "this review has had 5 rounds, so no more start, and the person decides", and the
design-acceptcommand to use. It used to say the review "hasn't started". - One notice per capped review. The Lead and the task hear once that a review reached the cap, however many plans follow it.
When you upgrade
- A plan stuck this way gets its review once the Planner marks it ready again with
bb factory plan-ready. Its last review already ended, so the plan starts a new one. - Nothing else to do. Reviews that ended before the upgrade are recognized from their rounds.
Limits
- Within one review, the cap is unchanged: after 5 rounds, you accept the plan as it is or send it back to the Planner.
- Not tried for real yet: the stuck plan hasn't been re-marked on this version.
Full Changelog: v0.4.5...v0.4.6